Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

feat: support bn256_pairing precompiled contract by Godwoken syscall #88

Merged
merged 20 commits into from
Nov 7, 2022
Merged

feat: support bn256_pairing precompiled contract by Godwoken syscall #88

merged 20 commits into from
Nov 7, 2022

Conversation

Flouse
Copy link
Collaborator

@Flouse Flouse commented Sep 22, 2021 •
edited
Loading

Previously, bn256_pairing precompiled contract was not supported due to too high cycle cost.

This PR implements bn256_pairing precompiled contract by introducing new Godwoken syscall:

sys_bn_pairing

Dependencies

Tests

test code:
https://github.com/Flouse/godwoken-polyjuice/blob/47865fc349d9485021b3e75205cfd621c1ada8e1/polyjuice-tests/src/test_cases/pre_compiled_contracts.rs#L163-L697

cmd:

cd polyjuice-tests/
cargo test --release -- test_bn256_add --nocapture 2>&1
cargo test --release -- test_bn256_scalar_mul --nocapture 2>&1
cargo test --release -- test_bn256_pairing --nocapture 2>&1
Test Case Elapsed Time (ms) Used Gas Used Cycles (virtual+execution)
Bn256Add 1 ~27K ~693K
Bn256ScalarMul <2 ~31K ~690K
Bn256Pairing one_point 5 ~105K ~918K
Bn256Pairing two_point_match_2 6 ~141K ~1024K
Bn256Pairing two_point_match_3 7 ~141K ~1024K
Bn256Pairing two_point_match_4 8 ~141K ~1024K
Bn256Pairing ten_point_match_1 22 ~432K ~1874K
Bn256Pairing ten_point_match_2 23 ~436K ~1874K
Bn256Pairing ten_point_match_3 8 ~142K ~1024K

@Flouse Flouse marked this pull request as ready for review September 22, 2021 13:41
@Flouse Flouse changed the title Support bn256_pairing_istanbul pre-compiled contract feat: Support bn256_pairing_istanbul pre-compiled contract Sep 22, 2021
@Flouse Flouse requested review from TheWaWaR and jjyr September 22, 2021 13:58
TheWaWaR
TheWaWaR previously approved these changes Sep 23, 2021
View reviewed changes
@Flouse Flouse marked this pull request as draft September 30, 2021 02:55
XuJiandong
XuJiandong suggested changes Sep 16, 2022
View reviewed changes
c/contracts.h Outdated Show resolved Hide resolved
c/generator.c Outdated Show resolved Hide resolved
@Flouse Flouse force-pushed the bn256-pairing branch 3 times, most recently from 4dc4d1e to c18cf7a Compare September 21, 2022 17:02
@Flouse Flouse requested a review from magicalne September 22, 2022 05:58
@Flouse Flouse self-assigned this Sep 27, 2022
@Flouse Flouse changed the title feat: Support bn256_pairing_istanbul pre-compiled contract feat: support bn256_pairing precompiled contract by Godwoken syscall Sep 30, 2022
@Flouse Flouse marked this pull request as ready for review October 8, 2022 07:05
@Flouse Flouse mentioned this pull request Oct 8, 2022
Merged
jjyr
jjyr previously approved these changes Oct 9, 2022
View reviewed changes
@Flouse Flouse added the enhancement New feature or request label Oct 9, 2022
@Flouse Flouse requested review from TheWaWaR and XuJiandong October 9, 2022 16:54
magicalne
magicalne previously approved these changes Oct 10, 2022
View reviewed changes
zeroqn
zeroqn previously approved these changes Oct 12, 2022
View reviewed changes
@Flouse Flouse dismissed stale reviews from zeroqn and magicalne via 3436a7e October 12, 2022 09:38
Flouse added 19 commits November 7, 2022 10:21
@Flouse
Fix stack pointer not aligned in ckb-vm
c26643a 
- nervosnetwork/ckb-vm#97
- nervosnetwork/ckb-c-stdlib#33
@Flouse
fix(fuzz): build libalt_bn128.o in Makefile of fuzz test
aa7d753 
fix(fuzz): unknown register name 't0' in asm

https://github.com/Flouse/godwoken-polyjuice/runs/3676372772?check_suite_focus=true#step:10:14
@Flouse
fix(CI): install riscv64imac-unknown-none-elf in build/libalt_bn128.a
1d2192a 
error[E0463]: can't find crate for `core`
  |
  = note: the `riscv64imac-unknown-none-elf` target may not be installed
  = help: consider downloading the target with `rustup target add riscv64imac-unknown-none-elf`
  = help: consider building the standard library from source with `cargo build -Zbuild-std`
@Flouse
Update helper.rs
7556540 
the gw prefix can filter out a lot unrelated log
@Flouse
Remove the temporal patch of CKB_SP_ALIGN
90d49b4 
## References:
- nervosnetwork/ckb-c-stdlib#33
- nervosnetwork/ckb-vm#97
@Flouse
deps: remove submodule bn128
6172809
@Flouse
git rm --cached deps/ckb-binary-patcher
c41fcfc
@Flouse
docs: update README.md
6883d46
@Flouse
feat: support bn256_pairing precompiled contract by Godwoken syscall
8a52169
@Flouse
deps: rm pairing cryptography library bn
6884592
@Flouse
test: add test cases for EIP-196 and EIP-197
38c14f5
@Flouse
chore(CI): Run Ethereum Test in a single step
cde3e62
@Flouse
chore: tune optimization level
fcca69b
@Flouse
test: refactor check_cycles in helper.rs
164eccf
@Flouse
chore: tune compiler flags
9db95d1
@Flouse
test: fix multicall3
5f42a17
@Flouse
fix(test): test_cases/pre_compiled_contracts.rs
23a3739
@Flouse
Bump POLYJUICE_VERSION to 1.5.0
7f2e92f
@Flouse
perf: activate compiler optimization for size
60dca4e
@jjyr jjyr requested review from XuJiandong and zeroqn and removed request for XuJiandong November 7, 2022 02:26
@jjyr jjyr merged commit 0cc7a81 into godwokenrises:main Nov 7, 2022
This was referenced Nov 13, 2022
Merged
Merged
@Flouse Flouse deleted the bn256-pairing branch November 15, 2022 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@XuJiandong XuJiandong XuJiandong approved these changes

@jjyr jjyr jjyr approved these changes

@magicalne magicalne magicalne approved these changes

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

@zeroqn zeroqn Awaiting requested review from zeroqn

Assignees

@Flouse Flouse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Flouse @jjyr @XuJiandong @TheWaWaR @magicalne @zeroqn