This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Fix partial state revert logic #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some assertions are removed those have little to do with polyjuice functionalities. - Revert tests are refactored. Because the original tests hit the "revert" error when access public global var. - Reset g_created_id in `revert`.
jjyr
suggested changes
Nov 4, 2022
jjyr
suggested changes
Nov 4, 2022
jjyr
approved these changes
Nov 4, 2022
zeroqn
approved these changes
Nov 4, 2022
RetricSu
approved these changes
Nov 4, 2022
Flouse
approved these changes
Nov 6, 2022
This was referenced Nov 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the revert issue is fixed with two new syscalls, sys_snapshot and sys_revert.
Snapshot of the state is taken before call/create and revert back if polyjuice gets an error from EVM.
If it's a
createtx, we need to resetg_created_idas well.The revert tests are also refactored because the old tests kept hitting a revert error when accessing the global variable(e.g. CallRevertWithTryCatch.state).