Add open_inputs to the list of exceptions
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very swift, thank you very much! |
|
Wait, this was the wrong branch surely, the CI checks against the 4.0 branch Yes indeed this branch is only for 3.x, it has 3.x syntax for GDScript |
|
I wanted to make a cherrypick, similar to what is done in gitlab, but I couldn't find this option via webui and I guess it is only available via gitlab desktop/cli (https://github.com/orgs/community/discussions/61621, isaacs/github#629) In that case, however, it is rather better to re-create the PR with the appropriate branch |
|
... Sorry for the inconvenience, I was linked the wrong branch indeed. This one could be reverted although it's not exactly harmful |
|
No harm done 🙂 just got to have it in the right place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for godotengine/godot#86713 to be merged.
All tests pass with the original name. But with "open_inputs" they do not.