Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orphan strings in AnimationNodeStateMachine #99934

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Dec 2, 2024

I've detected few orphan string errors (Start and End), which sometimes (not always) happens on even empty project (at project exit with verbose mode enabled). This will fix them from appearing.

@Chaosus Chaosus requested review from a team as code owners December 2, 2024 18:23
@Chaosus Chaosus added this to the 4.4 milestone Dec 2, 2024
@Chaosus Chaosus force-pushed the animation_node_state_machine_fix_orphan_strings branch from a0b473b to 119ed05 Compare December 2, 2024 18:32
@Chaosus Chaosus requested a review from a team as a code owner December 2, 2024 18:32
@Repiteo
Copy link
Contributor

Repiteo commented Dec 9, 2024

Will need a rebase before this can be merged

@Chaosus Chaosus force-pushed the animation_node_state_machine_fix_orphan_strings branch from 119ed05 to 7fd7e6c Compare December 10, 2024 08:04
@Chaosus
Copy link
Member Author

Chaosus commented Dec 10, 2024

@Repiteo Done!

@Chaosus Chaosus force-pushed the animation_node_state_machine_fix_orphan_strings branch from 7fd7e6c to 84cd354 Compare December 10, 2024 08:14
@Repiteo
Copy link
Contributor

Repiteo commented Dec 10, 2024

Uhh, sorry need another rebase

How in the world did this happen twice lmao

@Chaosus Chaosus force-pushed the animation_node_state_machine_fix_orphan_strings branch from 84cd354 to 7adb986 Compare December 11, 2024 08:08
@Chaosus Chaosus merged commit ff9d389 into godotengine:master Dec 11, 2024
20 checks passed
@Chaosus Chaosus deleted the animation_node_state_machine_fix_orphan_strings branch December 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants