Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FileAccess] Set last_error on file read/write errors. #99919

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[FileAccess] Set last_error on file read/write errors. #99919

merged 1 commit into from
Dec 3, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 2, 2024 •
edited
Loading

See #78289 comments.

Also changes eof_reached() to use feof directly, since write operations do not unset EOF flag, but do unset last error.

@bruvzg bruvzg added this to the 4.4 milestone Dec 2, 2024
@bruvzg bruvzg marked this pull request as ready for review December 2, 2024 12:46
@bruvzg bruvzg requested review from a team as code owners December 2, 2024 12:46
@Repiteo Repiteo merged commit 608cccc into godotengine:master Dec 3, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @Repiteo @adamscott