Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated note about BaseMaterial3D.billboard_mode shadow issue #99841

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Remove outdated note about BaseMaterial3D.billboard_mode shadow issue #99841

merged 1 commit into from
Nov 29, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 29, 2024 •
edited
Loading

The linked pull request was merged in Godot 4.3.

@Calinou
Remove outdated note about BaseMaterial3D.billboard_mode shadow issue
e499563 
The linked pull request was merged in Godot 4.3.
@Calinou Calinou requested a review from a team as a code owner November 29, 2024 18:57
@Calinou Calinou added bug documentation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 29, 2024
@Calinou Calinou added this to the 4.4 milestone Nov 29, 2024
Mickeon
Mickeon approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always hated this note regardless of the merged PR. 😤

@akien-mga akien-mga merged commit 31edb7e into godotengine:master Nov 29, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the doc-basematerial3d-billboard-mode-remove-outdated-note branch December 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @akien-mga @clayjohn @Mickeon