Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update example from Window signal files_dropped #99837

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

thiagola92
Copy link
Contributor

@thiagola92 thiagola92 commented Nov 29, 2024

As mentioned in godot-docs/issues/10318, switching to get_window() may be more appropriated as we are talking about a signal that only exist in Window.

Note: I think that this PR is so small that could be done together with another docs update.

Bugsquad edit: closes godotengine/godot-docs#10318

@thiagola92 thiagola92 requested a review from a team as a code owner November 29, 2024 14:48
@Mickeon Mickeon added this to the 4.4 milestone Nov 29, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely a remnant from 3.x, where Window did not exist and this signal was present in Viewport, so when this was copy-pasted the example did not account for it.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I said in the linked issue, seems like a logical change to me, but I'm not an expert at the relevant area.

Note: I think that this PR is so small that could be done together with another docs update.

For typos and style nitpicks in actual engine code, we do try to batch changes into bigger PRs. But for docs changes, as far as I know small atomic commits like this are perfectly fine, as long as they address an actual issue.

@akien-mga akien-mga merged commit 1745fe1 into godotengine:master Nov 29, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Docs: update example from Window signal files_dropped Docs: update example from Window signal files_dropped Nov 29, 2024
@akien-mga akien-mga changed the title Docs: update example from Window signal files_dropped Docs: Update example from Window signal files_dropped Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example on Window signal files_dropped
4 participants