Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Improve frame pacing by busy waiting as needed #99833

Merged

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Nov 29, 2024

Apply a solution similar to the one in #99178 to the frame delay function only.

Fixes #99728 (implemented for windows only as describe in #99728 (comment) since other platform doesn't seem affected).

@Faless Faless force-pushed the fix/sleepy_windows_becomes_a_heater branch 3 times, most recently from 0b1348b to b57ceef Compare November 29, 2024 17:21
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. This seems to cover the most needed changes from #99178 and #99656 (leaving out the changes intended for Unix).

I tested locally and confirmed that this is working correctly.

@akien-mga
Copy link
Member

Thanks!

@Faless Faless deleted the fix/sleepy_windows_becomes_a_heater branch November 30, 2024 18:36
JekSun97 pushed a commit to JekSun97/godot that referenced this pull request Dec 2, 2024
…ecomes_a_heater

[Windows] Improve frame pacing by busy waiting as needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine.max_fps has bad frame pacing due to inaccurate OS sleep functions
4 participants