-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VoxelGI bake canceling and progress UI improvement #99562
Merged
Repiteo
merged 1 commit into
godotengine:master
from
badsectoracula:improve_voxelgi_bake_ui
Nov 25, 2024
Merged
Add VoxelGI bake canceling and progress UI improvement #99562
Repiteo
merged 1 commit into
godotengine:master
from
badsectoracula:improve_voxelgi_bake_ui
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 22, 2024
5eb6db9
to
ff9a788
Compare
clayjohn
reviewed
Nov 22, 2024
Calinou
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
I didn't notice any memory leaks when canceling the bake at various points in time.
ff9a788
to
7598ac6
Compare
7598ac6
to
da19116
Compare
clayjohn
approved these changes
Nov 25, 2024
AThousandShips
approved these changes
Nov 25, 2024
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the "Cancel" button in the VoxelGI baking progress window similar to #99483 and improves the progress UI so that it shows the current progress in a more granular fashion (i.e. it takes into account the combined work the meshes to plot and adds SDF building progress).
Like with the lightmap build, i mainly tested it with the global illumination demo, though i had to increase the subdivision to 512. In devbuilds the process is much slower and easier to test for leaks, etc. In production build the slowest part is SDF building (which is also the part that previously had no progress report).
This does slow down the baking progress a bit but the difference is an increase of about 1.13% on my PC. With 5 runs with and without the PR in a production build the baking time increased from an average of 15319 millseconds (~15.3 seconds) to 15493 milliseconds (~15.5 seconds), which i think is acceptable as with small voxel boxes it wouldn't make a noticeable difference but with larger voxel boxes you'd want some way to monitor the progress and cancel the bake.