Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VoxelGI bake canceling and progress UI improvement #99562

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

badsectoracula
Copy link
Contributor

This enables the "Cancel" button in the VoxelGI baking progress window similar to #99483 and improves the progress UI so that it shows the current progress in a more granular fashion (i.e. it takes into account the combined work the meshes to plot and adds SDF building progress).

Like with the lightmap build, i mainly tested it with the global illumination demo, though i had to increase the subdivision to 512. In devbuilds the process is much slower and easier to test for leaks, etc. In production build the slowest part is SDF building (which is also the part that previously had no progress report).

This does slow down the baking progress a bit but the difference is an increase of about 1.13% on my PC. With 5 runs with and without the PR in a production build the baking time increased from an average of 15319 millseconds (~15.3 seconds) to 15493 milliseconds (~15.5 seconds), which i think is acceptable as with small voxel boxes it wouldn't make a noticeable difference but with larger voxel boxes you'd want some way to monitor the progress and cancel the bake.

@badsectoracula badsectoracula force-pushed the improve_voxelgi_bake_ui branch 2 times, most recently from 5eb6db9 to ff9a788 Compare November 22, 2024 20:41
@clayjohn clayjohn modified the milestones: 4.x, 4.4 Nov 22, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

I didn't notice any memory leaks when canceling the bake at various points in time.

@badsectoracula badsectoracula force-pushed the improve_voxelgi_bake_ui branch from ff9a788 to 7598ac6 Compare November 23, 2024 19:10
@badsectoracula badsectoracula force-pushed the improve_voxelgi_bake_ui branch from 7598ac6 to da19116 Compare November 23, 2024 19:14
@Repiteo Repiteo merged commit 5b11eb6 into godotengine:master Nov 25, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 25, 2024

Thanks!

@badsectoracula badsectoracula deleted the improve_voxelgi_bake_ui branch November 25, 2024 22:05
@akien-mga akien-mga changed the title Add VoxelGI bake cancelling and progress UI improvement Add VoxelGI bake canceling and progress UI improvement Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants