ResourceLoader: Report appropriate error code when no suitable loader is found #99494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomShaper
added
bug
topic:core
cherrypick:4.3
RandomShaper
force-pushed
the
rerefix_res_unrecog
branch
from
bbfc8a1 to
f79b972
Compare
RandomShaper
changed the title
RandomShaper
commented
Nov 22, 2024
| @@ -316,14 +316,34 @@ Ref<Resource> ResourceLoader::_load(const String &p_path, const String &p_origin | |||
| return res; | |||
| } | |||
|
|
|||
| #ifdef TOOLS_ENABLED | |||
| if (Engine::get_singleton()->is_editor_hint()) { | |||
There was a problem hiding this comment.
Restricting this to editor sessions (and not just editor builds) because at runtime many types are not registered with the importer and therefore the check below would be less reliable. That way, we have two behaviors only: editor and runtime, and not an in-between third one, that would make things unnecessarily complex.
akien-mga
approved these changes
Jan 11, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of the reverted #97370.
One difference worth mentioning compared to the reverted PR is that, in order to make a simpler diff, reporting the file doesn't
exist is more prioritary than telling the extension is unknown. I don't think we have reasons to prefer one over the other.
E.g., loading
thing.aaa, which doesn't exist:ERR_FILE_UNRECOGNIZED.ERR_FILE_NOT_FOUND.If the file exists, then this PR will then do report
ERR_FILE_UNRECOGNIZED.Fixes #95490.