-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDScript: Support tracking multiple analyzer and runtime errors in tests #99490
GDScript: Support tracking multiple analyzer and runtime errors in tests #99490
Conversation
20dd4f8
to
f5b0d77
Compare
f5b0d77
to
1d7e920
Compare
1d7e920
to
5272b83
Compare
5272b83
to
f86dcd4
Compare
So warnings now have use a |
Yes, warnings are not produced in release builds, so we need a marker to cut only them but leave errors. godot/modules/gdscript/tests/gdscript_test_runner.cpp Lines 173 to 181 in f86dcd4
This doesn't matter now, since GDScript tests don't seem to run for release builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codestyle checks out! Should make creating tests MUCH more intuitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Currently, the GDScript test system has a problem: it does not allow us to track multiple errors. Because of this, we have to have many small files for error tests, unlike warning and feature tests.
While this limitation is justified for parser tests due to cascading errors, I think there is no obstacle for analyzer and runtime tests to track multiple errors. Probably, using
=
instead of+=
inmodules/gdscript/tests/gdscript_test_runner.cpp
is even a bug, leading to overwriting the output, so we only track the last error.This PR allows:
How to make multiple subtests of runtime errors within one test:
Note: I did not combine all groups of similar tests within this PR.