Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix viewport message offsets #99487

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix viewport message offsets #99487

merged 1 commit into from
Nov 22, 2024

Conversation

passivestar
Copy link
Contributor

A small UI fix, makes info messages follow the same margins as the rest of viewport overlays

g

@passivestar passivestar requested review from a team as code owners November 21, 2024 04:27
@timothyqiu timothyqiu added this to the 4.x milestone Nov 21, 2024
fire
fire approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a way to change the magic numbers so they are not so magic?

@passivestar
Copy link
Contributor Author

Is there a way to change the magic numbers so they are not so magic?

10 is also hardcoded for all of the other overlays and I'm not sure if it needs to be themable (probably not?). as for the 14 I tried putting get_descent() in there but with no success, the results were just way off. Docs say it's just an approximation

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Nov 22, 2024
@Repiteo Repiteo merged commit eedc820 into godotengine:master Nov 22, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 22, 2024

Thanks!

@passivestar passivestar deleted the fix-viewport-offsets branch November 22, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@Repiteo Repiteo Repiteo approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@passivestar @Repiteo @fire @timothyqiu