Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCons: Misc improvements #99472

Merged
merged 1 commit into from
Nov 22, 2024
Merged

SCons: Misc improvements #99472

merged 1 commit into from
Nov 22, 2024

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Nov 20, 2024

  • Delete old gcc 7 check
  • Use f-strings where it is easy
  • Use AddVariables instead of Add for collections of options

@dustdfg
SCons: Misc improvements
0896bdd 
* Delete old gcc 7 check
* Use f-strings where it is easy
* Use AddVariables instead of Add for collections of options

Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]>
@dustdfg dustdfg requested a review from a team as a code owner November 20, 2024 16:20
@AThousandShips AThousandShips added this to the 4.x milestone Nov 20, 2024
akien-mga
akien-mga approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Nov 20, 2024
adamscott
adamscott reviewed Nov 20, 2024
View reviewed changes
@Repiteo Repiteo merged commit 03d9d4f into godotengine:master Nov 22, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 22, 2024

Thanks!

@dustdfg dustdfg deleted the scons_misc_sconstruct_tidying branch November 22, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@dustdfg @Repiteo @adamscott @akien-mga @AThousandShips