Add root_motion_local option to AnimationMixer to pre-multiply root motion rotation accumulator before blending
#99394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
root-local
branch
2 times, most recently
from
7051dae to
4b7805b
Compare
|
Works great and significantly simplifies implementing root motion. |
fire
approved these changes
Nov 18, 2024
TokageItLab
force-pushed
the
root-local
branch
from
4b7805b to
755bcf4
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting local root motion translation with the accumulator was implemented/described in #72931, but when there is a fade, the local translation is not extracted correctly because the rotation of animation B affects the extraction of the local translation of animation A which may have different rotation.
Add an option to extract local moves before blending. The default is
falsedue to keep compatibility and there are some performance concerns.Also contain some minor fix for missing
post_process_key_value().