Windows: Expand godot.natvis type coverage
#99042
Conversation
| if env.msvc: | ||
| env.Depends(prog, "godot.natvis") |
There was a problem hiding this comment.
Technically it's only a dependency with env["vsproj"], no?
There was a problem hiding this comment.
Actually, no! The file can be used when debugging even without a Visual Studio project, provided it's properly assigned. I debug in VSCode almost exclusively, and it ztill works
There was a problem hiding this comment.
But it's not compiled into the binary in these cases, is it?
Doesn't this imply that a change to the .natvis file means recompiling the whole engine?
There was a problem hiding this comment.
It recompiles the link step on the executable, so not the whole engine. Truthfully, I'm not sure what the deal with it is, beyond that it needed to be relinked before changes showed up in the debugger
There was a problem hiding this comment.
Oh right my bad, it is passed to the linker:
platform/windows/detect.py
599: env.Append(LINKFLAGS=["/NATVIS:platform\\windows\\godot.natvis"])
Repiteo
force-pushed
the
windows/natvis-improvements
branch
from
48e2b4d to
9bf6288
Compare
Adds several new types to
godot.natvis, particularly the Variant structs. Makes the display string representation equivalent to their String operator output where possible. Additionally, this addsgodot.natvisas a dependancy to the executable itself, meaning editing just that file will trigger a relink on build. Also in testing, TypedArray already inherits debug display from Array, so that redundant section was removed