Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Net] Split Unix/Windows IP implementation #99026

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[Net] Split Unix/Windows IP implementation #99026

merged 1 commit into from
Nov 18, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Nov 10, 2024

Continuation of #98969 , as mentioned in this comment together they may allow us to exclude the drivers folder depending on the platform.

@Faless Faless requested review from a team as code owners November 10, 2024 14:56
@AThousandShips AThousandShips added this to the 4.x milestone Nov 10, 2024
Repiteo
Repiteo approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codestyle checks out. A followup PR should look into the actual exclusion process of the drivers folder, but this is fine to merge as-is

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Nov 18, 2024
@Repiteo Repiteo merged commit 1dcb686 into godotengine:master Nov 18, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 18, 2024

Thanks!

@Faless Faless deleted the net/split_ip branch November 18, 2024 15:53
@gofastlily gofastlily mentioned this pull request Jan 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@Repiteo Repiteo Repiteo approved these changes

Assignees
No one assigned
Labels
enhancement topic:network
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Faless @Repiteo @mhilbrunner @AThousandShips