Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more miscellaneous oddities around the class reference #99002

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Nov 9, 2024

Continuation of #95774
See also #89036

This PR addressed yet another huge chunk of class reference oddities I remembered to note down for later while localizing the class reference. Some of these are clear typos, some are inconsistencies, some are just awkward.

I decided to separate this from the original because these may be more prickly.

Of particular note:

  • Fix some things that were fixed in Overhaul some "uncommon" wording in class reference #89036 but came back in full force because I cannot be behind every contributor's back.
  • PROPERTY_USAGE_CLASS_IS_ENUM called the property an "enum", whereas it's probably closer to an enum type variable, which is less ambiguous.
  • Replace the few uses of "acquire", "interrogate", and "augment" with more common verbs.
  • Replace leftover references to "spatial node" from 3.x.
  • NEVER write "The node (and any relevant children) should be [member CanvasItem.visible]" ever again. I'm going to cry.

For the descriptions affected, not many tweaks have been made this time. Who knows when this will be merged anyway.

@Mickeon Mickeon added this to the 4.4 milestone Nov 9, 2024
@Mickeon Mickeon requested a review from a team as a code owner November 9, 2024 20:54
@Mickeon Mickeon force-pushed the documentation-more-miscellaneous-oddities branch from 90d1792 to 32b42fd Compare November 9, 2024 20:56
@Mickeon Mickeon requested a review from a team as a code owner November 9, 2024 20:56
@Mickeon Mickeon removed the request for review from a team November 9, 2024 20:56
@Mickeon Mickeon force-pushed the documentation-more-miscellaneous-oddities branch from 32b42fd to e1f1150 Compare November 9, 2024 21:23
@Mickeon Mickeon requested a review from a team as a code owner November 9, 2024 21:23
@Mickeon Mickeon removed the request for review from a team November 10, 2024 18:08
@Mickeon Mickeon force-pushed the documentation-more-miscellaneous-oddities branch from e1f1150 to 6b15ecd Compare November 11, 2024 11:04
@Mickeon
Copy link
Contributor Author

Mickeon commented Nov 11, 2024

Updated the PR to replace these random tabulation characters

doc/classes/Object.xml Outdated Show resolved Hide resolved
@Mickeon Mickeon force-pushed the documentation-more-miscellaneous-oddities branch from 6b15ecd to 8c5584d Compare November 11, 2024 20:24
@Mickeon Mickeon force-pushed the documentation-more-miscellaneous-oddities branch from 8c5584d to eaebb3f Compare November 12, 2024 16:44
@Mickeon
Copy link
Contributor Author

Mickeon commented Nov 12, 2024

Rebased after minor conflict.

@Repiteo Repiteo merged commit f1d3130 into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

@Mickeon Mickeon deleted the documentation-more-miscellaneous-oddities branch November 12, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants