Fix engine_type_colors's description
#98966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
engine_type_colors's description
|
Please restore the translation files, they are handled elsewhere, see the instructions |
AThousandShips
added
bug
documentation
cherrypick:4.2
|
I have restored the translation files to their previous state(and accidentally closed my pr. I apologize for that. its my first pr) |
AThousandShips
approved these changes
Nov 8, 2024
|
yeah, that describes it better |
|
Please squash your commits into one, see the interactive rebase for instructions |
Dr-helicopter
force-pushed
the
master
branch
2 times, most recently
from
6c749b9 to
42ea239
Compare
in editor>editor settings>Text Editor>Theme, if you hover hover over "Engine Type Color", it has "Vector2", "Vector3"and "Color" as example but these are not Engine types. and their color is controlled by the "Base Type Color" setting. I discovered this while trying to customize my editor a bit more.
|
anything else? |
|
No this should be ready to go, the production team will take a look when they do a pass over PRs to merge and comment if something else is needed |
|
Thanks! Congratulations on your first contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in editor>editor settings>Text Editor>Theme, if you hover hover over "Engine Type Color", it has "Vector2", "Vector3"and "Color" as example but these are not Engine types. and their color is controlled by the "Base Type Color" setting. I discovered this while trying to customize my editor a bit more.