Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix immersive mode issue #98917

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 commented Nov 7, 2024

This PR resolves this issue, but the exact cause remains unclear. Interestingly, this issue only seems to occur on older Android versions; so far, it’s reproducible on Android 10 and 11 but not on Android 14.

The issue is likely due to Android 10 and 11 handling immersive mode differently than Android 14. On these versions, the initial immersive mode activation may not fully take effect due to timing or UI initialization quirks, causing the system bars to reappear on the first screen touch.

This PR solves this issue by re-enabling the immersive mode onGodotMainLoopStarted()

Test apk ARM64: Demo app.zip

Test apk ARM32: demo app (arm32).zip

@syntaxerror247 syntaxerror247 requested a review from a team as a code owner November 7, 2024 10:06
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 7, 2024
@syntaxerror247 syntaxerror247 marked this pull request as draft November 7, 2024 12:04
@syntaxerror247 syntaxerror247 marked this pull request as ready for review November 7, 2024 13:40
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the change and it fixes the issue as described!

@akien-mga akien-mga merged commit a702b69 into godotengine:master Dec 2, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@syntaxerror247 syntaxerror247 deleted the immersive-mode-issue branch December 5, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android navigation bar appear after touch on apk exported game in immersive mode (Android 11, 10)
4 participants