-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] Ensure editor crossorigin isolation headers #98901
[Web] Ensure editor crossorigin isolation headers #98901
Conversation
Code seems ok to me, but adding this kind of build option seems really niche. I don't fully understand who would use this option and when? |
The issue right now is that the editor build is somewhat broken. And I don't like the idea of enforcing COI headers for editor builds. |
Why do we need a compile time option for this instead of just performing this change if |
You're right. The SW even checks for the headers before applying them, so if the server is already setup, no cry no foul. |
ea49178
to
1a082fd
Compare
@akien-mga I simplified the PR, I enforce the placeholder to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The rationale makes sense to me as threads are a hard requirement for the web editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
Follow-up to #86089.
An error prevents the registration of the service worker for the editor Web build.
This PR ensures that
___GODOT_ENSURE_CROSSORIGIN_ISOLATION_HEADERS___
is being replaced in the service worker for the editor build.