-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
certs: Sync with Mozilla bundle as of Oct 19, 2024 #98855
Conversation
Am I correctly understand that it will affect only git repo without affecting binary at all? |
There's two elements in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the relevant file local makes sense for future proofing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superfluous, but harmless
Actually I'll rework this, I'm having second thoughts about including a source file of cryptic data in our repo when we don't need it. Instead, I'll included the hash of the relevant Mozilla commit used by bagder in |
Here’s a tip (since I had to find a bunch of these in order to add the table to the ca-bundle README): the most surefire way to find the hash is to go to here and then find the push that came right before the timestamp that’s in |
bagder/ca-bundle@4d3fe66 Document matching mozilla-release changeset.
Cherry-picked for all Git branches ( |
bagder/ca-bundle@4d3fe66
Include
certdata.txt
as the original source for the processed data.I'll cherry-pick this to all Godot branches, including EOL ones, which should resolve #98851.