Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certs: Sync with Mozilla bundle as of Oct 19, 2024 #98855

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Nov 5, 2024

bagder/ca-bundle@4d3fe66

Include certdata.txt as the original source for the processed data.

I'll cherry-pick this to all Godot branches, including EOL ones, which should resolve #98851.

@akien-mga akien-mga added enhancement topic:thirdparty cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Nov 5, 2024
@akien-mga akien-mga added this to the 4.4 milestone Nov 5, 2024
@akien-mga akien-mga requested a review from a team as a code owner November 5, 2024 15:54
@dustdfg
Copy link
Contributor

dustdfg commented Nov 5, 2024

Am I correctly understand that it will affect only git repo without affecting binary at all?

@akien-mga
Copy link
Member Author

akien-mga commented Nov 5, 2024

Am I correctly understand that it will affect only git repo without affecting binary at all?

There's two elements in this PR:

  • ca-certificates.crt is updated to a newer version, this affects binaries by removing outdated CA certificates and adding new valid ones.
  • certdata.txt is provided for documentation purposes and isn't used anywhere. It's just adding 1.5 MB of diff to our Git history for the sake of satisfying a license claim I'm doubtful about, but heh /shrug

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the relevant file local makes sense for future proofing

Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous, but harmless

@akien-mga
Copy link
Member Author

Actually I'll rework this, I'm having second thoughts about including a source file of cryptic data in our repo when we don't need it. Instead, I'll included the hash of the relevant Mozilla commit used by bagder in thirdparty/README.md.

@akien-mga akien-mga marked this pull request as draft November 5, 2024 18:54
@Jayman2000
Copy link
Contributor

Instead, I'll included the hash of the relevant Mozilla commit used by bagder in thirdparty/README.md.

Here’s a tip (since I had to find a bunch of these in order to add the table to the ca-bundle README): the most surefire way to find the hash is to go to here and then find the push that came right before the timestamp that’s in ca-certificates.crt. I had originally tried doing this with hg log instead of the pushlog, but it didn’t work well because some commits were made on one date but then pushed to the relevant branch on a later date. The pushlog is the way to go.

@akien-mga akien-mga marked this pull request as ready for review November 5, 2024 19:43
@akien-mga akien-mga merged commit 2ad452a into godotengine:master Nov 5, 2024
20 checks passed
@akien-mga akien-mga deleted the ca-certs branch November 5, 2024 20:09
@akien-mga
Copy link
Member Author

Cherry-picked for all Git branches (4.3, 4.2, 4.1, 4.0, 3.x, 3.6, 3.5, etc. down to 2.1, which is the first release with ca certificates).

@akien-mga akien-mga removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Older unsupported releases are violating the MPL 2.0 due to a broken link
5 participants