Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close toasts instantly when Close button is pressed #98797

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Close toasts instantly when Close button is pressed #98797

merged 1 commit into from
Nov 11, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 3, 2024

Makes the toast close instantly instead of fading.

godot.windows.editor.dev.x86_64_bt8pDlO2VW.mp4

Toasts closed by timeout are still fading.

@KoBeWi KoBeWi added this to the 4.x milestone Nov 3, 2024
@KoBeWi KoBeWi requested review from a team as code owners November 3, 2024 14:05
Calinou
Calinou approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 1bffd6c), it works as expected.

@clayjohn clayjohn modified the milestones: 4.x, 4.4 Nov 5, 2024
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Needs a rebase before this can be merged

@Repiteo Repiteo merged commit cea186a into godotengine:master Nov 11, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks!

@KoBeWi KoBeWi deleted the toastkill_f branch November 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@Repiteo Repiteo Repiteo approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @Repiteo @Calinou @clayjohn