Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SceneStringName in more places #98763

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Use SceneStringName in more places #98763

merged 1 commit into from
Dec 2, 2024

Conversation

AThousandShips
Copy link
Member

Mainly cases involving text_submitted but a few other stragglers as well

@AThousandShips AThousandShips added this to the 4.x milestone Nov 2, 2024
@AThousandShips AThousandShips requested review from a team as code owners November 2, 2024 16:19
Mickeon
Mickeon approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I wonder if this is actually faster, but this change is consistent with the codebase and doesn't affect surrounding code.

@AThousandShips
Copy link
Member Author

It will unconditionally be faster than raw strings, and saves memory compared to SNAME

@Mickeon Mickeon modified the milestones: 4.x, 4.4 Nov 13, 2024
@akien-mga
Copy link
Member

Needs rebase.

@akien-mga akien-mga merged commit e6125ef into godotengine:master Dec 2, 2024
20 checks passed
@AThousandShips AThousandShips deleted the more_sname_uses branch December 2, 2024 14:55
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @akien-mga @Mickeon