Allow multiple platform API files #98700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, platforms can implement a public API. This is hardcoded to be built from
{platform}/api.hand{platform}/api.cpp.While this works and is useful, some platforms provide a fairly large API. Trying to keep all that in those two files becomes painful quickly.
This simple change allows one to split up the API implementation into multiple files. It changes nothing for existing implementations, but optionally allows one to have e.g.
api/achievements.cpp,api/networking.cppandapi/specialplatformstorage.cppbe also included in the build, without having to modify the Godot source or build system when adding a custom platform implementation.