Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mark PROPERTY_USAGE_NO_EDITOR properties for translation #98571

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Don't mark PROPERTY_USAGE_NO_EDITOR properties for translation #98571

merged 1 commit into from
Nov 6, 2024

Conversation

timothyqiu
Copy link
Member

Using PNAME() on these properties are redundant as they won't be displayed in the editor and some of them will be automatically ignored by the extraction script.

@timothyqiu
Don't mark PROPERTY_USAGE_NO_EDITOR properties for translation
d47425b 
Using `PNAME()` on these properties are redundant as they won't be displayed
in the editor and some of them will be automatically ignored by the
extraction script.
@timothyqiu timothyqiu added this to the 4.4 milestone Oct 27, 2024
@timothyqiu timothyqiu requested review from a team as code owners October 27, 2024 01:16
@Mickeon Mickeon removed the request for review from a team October 30, 2024 10:50
Mickeon
Mickeon previously approved these changes Oct 30, 2024
View reviewed changes
@Mickeon Mickeon dismissed their stale review November 4, 2024 14:54

Second thoughts

@Mickeon Mickeon self-requested a review November 4, 2024 14:55
@timothyqiu
Copy link
Member Author

Note that this is not making a new decision. The decision not to parse properties with a PROPERTY_USAGE_NOEDITOR hint was made when PNAME() was introduced in #61141. Such properties are excluded from properties.pot for editor translation.

This PR is mainly a cleanup of unnecessary PNAME()s that have been added recently. There are also properties whose PROPERTY_USAGE_NOEDITOR hint was added later, so the PNAME() needs to be removed.

Mickeon
Mickeon approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the much-needed clarification.

@Repiteo Repiteo merged commit 6cef0a1 into godotengine:master Nov 6, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 6, 2024

Thanks!

@timothyqiu timothyqiu deleted the pname-no-editor branch November 6, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:i18n
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@timothyqiu @Repiteo @KoBeWi @Mickeon @akien-mga