Skip Vulkan SDK installation in macOS if it is already installed. #98510
Conversation
| @@ -3,6 +3,11 @@ | |||
| set -euo pipefail | |||
| IFS=$'\n\t' | |||
|
|
|||
| if [ -d "$HOME/VulkanSDK" ]; then | |||
There was a problem hiding this comment.
If I recall correctly godot engine uses the builtin system. Might want to investigate reusing that. This is simpler though.
There was a problem hiding this comment.
Not sure about this.
I think most users would expect to get VulkanSDK updated if it's already installed.
For the workers that are running in the persistent environment, it would make more sense to run this script as a cron task to update to the new version once a week, instead of running in every time.
Ideally it should check for installed available version, it can be done by downloading https://sdk.lunarg.com/sdk/download/latest/mac/config.json first, and checking version value from it against the list of the subfolders in $HOME/VulkanSDK.
|
Closing as superseded by #98608 |
Skip installation of Vulkan SDK if it is already installed.
This is useful when setting up user-hosted workers that run under the same environment every time.