Fix some flickering tooltips #98479
Merged
Fix some flickering tooltips #98479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98449
On mouse movement,
Viewportcancels current tooltip if the control's tooltip text is empty. On Windows, it appears that a mouse movement event is automatically generated when a tooltip is shown, so a button's tooltip flickers if it's only showing shortcut information without actualtooltip_text.The empty string check was introduced in #5803 to address another tooltip flickering issue 🤣 It seems to be a redundant check, testing for text change should be sufficient.