Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SceneRPCInterface: Sort rpc names using StringLikeVariantOrder #98472

Merged
merged 1 commit into from
Nov 11, 2024
Merged

SceneRPCInterface: Sort rpc names using StringLikeVariantOrder #98472

merged 1 commit into from
Nov 11, 2024

Conversation

rune-scape
Copy link
Contributor

No description provided.

@rune-scape rune-scape requested a review from a team as a code owner October 23, 2024 20:53
AThousandShips
AThousandShips approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving, the drawback is potential loss of performance by not having a likely

modules/multiplayer/scene_rpc_interface.cpp Outdated Show resolved Hide resolved
@AThousandShips AThousandShips modified the milestones: 4.x, 4.4 Oct 24, 2024
@clayjohn
Copy link
Member

Is the goal of this PR just to avoid code duplication? Or is there an intended behaviour difference in this sorting function?

@rune-scape
Copy link
Contributor Author

just to avoid code duplication

@Repiteo Repiteo merged commit def34fb into godotengine:master Nov 11, 2024
20 checks passed
@rune-scape rune-scape deleted the sort-rpc branch November 12, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:multiplayer
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@rune-scape @clayjohn @akien-mga @AThousandShips @Repiteo