Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify tiling of AtlasTexture #98458

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 23, 2024

Closes #5660

@KoBeWi KoBeWi added this to the 4.4 milestone Oct 23, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner October 23, 2024 13:24
@arkology
Copy link
Contributor

Is it a documentation issue if tiling worked before (according to #5660 (comment))?

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 23, 2024

Seems like it works if you set region of the AtlasTexture itself, not Sprite2D or TextureRect.

@KoBeWi KoBeWi force-pushed the don't_repeat_the_same_mistakes branch from 9c0d8dc to 8da268f Compare October 23, 2024 18:49
@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 23, 2024

Pushed additional note.

@KoBeWi KoBeWi force-pushed the don't_repeat_the_same_mistakes branch from 8da268f to 3ebac90 Compare October 23, 2024 21:03
@Repiteo Repiteo merged commit e2bd0a8 into godotengine:master Oct 24, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 24, 2024

Thanks!

@KoBeWi KoBeWi deleted the don't_repeat_the_same_mistakes branch October 24, 2024 18:44
@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 28, 2024

I realized that suggesting region as workaround makes no sense, because it's functional only if you are tiling the whole texture. It won't work if you want to tile part of the texture (e.g. frame in spritesheet).

@Mickeon
Copy link
Contributor

Mickeon commented Oct 28, 2024

Would we rather revert this and/or not recommend anything?

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 28, 2024

I'd just remove the last sentence, the other part is correct.
There are supposedly some workarounds, like using shaders, but it's probably too complex to explain here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AtlasTexture does not repeated in sprites
5 participants