[Legacy color picker] Use zoomed preview at the mouse position instead of Label.

[bruvzg]

Replaces the label with a 3x zoom preview that is following mouse cursor.

Screen.Recording.2024-10-22.at.11.15.10.mov

Can be combined with #88950 to do the same for a normal color picker.

[Calinou]

I get a compilation error on MSVC 2022:

Compiling scene\gui\popup_menu.cpp ...
scene\gui\color_picker.cpp(1576): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1576): error C2672: '_post_initialize': no matching overloaded function found
C:\Users\Hugo\Documents\Git\godotengine\godot\core/os/memory.h(120): note: could be 'T *_post_initialize(T *)'
scene\gui\color_picker.cpp(1577): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1578): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1579): error C2664: 'void Node::add_child(Node *,bool,Node::InternalMode)': cannot convert argument 1 from 'Panel *' to 'Node *'
scene\gui\color_picker.cpp(1579): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or parenthesized function-style cast
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/main/node.h(455): note: see declaration of 'Node::add_child'
scene\gui\color_picker.cpp(1579): note: while trying to match the argument list '(Panel *)'
scene\gui\color_picker.cpp(1581): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1581): error C2672: '_post_initialize': no matching overloaded function found
C:\Users\Hugo\Documents\Git\godotengine\godot\core/os/memory.h(120): note: could be 'T *_post_initialize(T *)'
scene\gui\color_picker.cpp(1582): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1583): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1584): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1585): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1591): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1594): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1597): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scene\gui\color_picker.cpp(1666): error C2027: use of undefined type 'Panel'
C:\Users\Hugo\Documents\Git\godotengine\godot\scene/gui/control.h(42): note: see declaration of 'Panel'
scons: *** [scene\gui\color_picker.windows.editor.x86_64.obj] Error 2
scons: building terminated because of errors.

[bruvzg]

I get a compilation error on MSVC 2022

Rebased and updated, this should be fixed now.

[Riteo]

Hi, note that this causes a regression with the canvas_items scaling mode. See #97212.

[KoBeWi]

You can use minimum size instead of size, so ignore will work correctly.

[bruvzg]

Hi, note that this causes a regression with the canvas_items scaling mode.

Working in canvas_items scaling mode should be fixed.

Zoom preview is a bit blurry in a scaled mode.

[Calinou]

Zoom preview is a bit blurry in a scaled mode.

This may be due to #86563. I've been meaning to investigate that one for a while, likely using RenderDoc to make sure the glyph texture sizes match the size that should be used according to the oversampling factor and viewport resolution.

[KoBeWi]

I just noticed that you are extracting an image only to make a texture. You could use AtlastTexture instead and set region.

[KoBeWi]

Looks like a nice improvement. The non-legacy picking could get the same treatment, but it's more tricky.

I added one more comment, but it's not super critical.

[Calinou]

Tested locally, it works as expected.

[bruvzg]

The non-legacy picking could get the same treatment, but it's more tricky.

I have updated #88950 to do the same for native picker.

[bruvzg]

Superseded by #88950 (not includes the same for both native and legacy pickers).