Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WS] Implement wslay unbuffered message parsing #98343

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[WS] Implement wslay unbuffered message parsing #98343

merged 1 commit into from
Nov 12, 2024

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Oct 19, 2024 •
edited
Loading

Ensure we never read more than we can store during poll.

Raise default max packets to 4096 to maintain the same performance for the first 2048 packets.

Fixes #70738

Closes #98167

@Faless Faless added this to the 4.4 milestone Oct 19, 2024
@Faless Faless requested review from a team as code owners October 19, 2024 18:51
@mhilbrunner mhilbrunner mentioned this pull request Nov 12, 2024
Merged
mhilbrunner
mhilbrunner approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style, commit and code look good, and I built a build with both #97913 and #98343 to do some testing.

I found no issues so far, and would like to see both tested in a dev release ASAP to get feedback on real projects.

@akien-mga akien-mga mentioned this pull request Nov 12, 2024
Closed
@Faless
[WS] Implement wslay unbuffered message parsing
3114bda 
Ensure we never read more than we can store during poll.

Raise default max packets to 4096 to maintain the same performance for
the first 2048 packets.
@Faless Faless force-pushed the ws/wslay_unbuffered branch from de37da2 to 3114bda Compare November 12, 2024 16:20
@Repiteo Repiteo merged commit 7ff6591 into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

@Spartan322 Spartan322 mentioned this pull request Nov 12, 2024
Merged
@Faless Faless deleted the ws/wslay_unbuffered branch November 12, 2024 22:06
@Faless Faless mentioned this pull request Dec 20, 2024
Merged
This was referenced Jan 25, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
bug topic:network
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Websocket dropping data violates TCP reliability and congestion control
3 participants
@Faless @Repiteo @mhilbrunner