Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve _begin_customize_scenes description #98265

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 commented Oct 17, 2024

This PR Improves _begin_customize_scenes() description and clears confusion about _customize_scene() not being called.

Closes #96104

Copy link
Member

@timothyqiu timothyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The writing side of the documentation is fine. I can also confirm that the modification times are indeed compared before calling _customize_scene().

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Oct 30, 2024
@Repiteo Repiteo merged commit 7c7de0e into godotengine:master Oct 30, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2024

Thanks!

@syntaxerror247 syntaxerror247 deleted the patch-2 branch October 30, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_customize_scene() is not called during Android export
5 participants