Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some strings not caught by editor pseudolocalization #98253

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Oct 17, 2024

Currently, editor pseudolocalization is activated after the creation of EditorNode / ProjectManager. Thus strings translated via TTR() in the constructor are not affected by pseudolocalization.

This PR moves the activation of editor pseudolocalization before the creation of those two objects.

@timothyqiu timothyqiu added this to the 4.4 milestone Oct 17, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner October 17, 2024 01:42
@timothyqiu timothyqiu requested a review from bruvzg October 24, 2024 03:05
@Repiteo Repiteo merged commit 0a847f7 into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

@timothyqiu timothyqiu deleted the its-too-late branch November 12, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants