Fix spinbox scrolling for advanced importer controls. #98016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbdev
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
According to #52266 (comment), these should have all been removed but only the precision one was.
Tested and it looks good.
akien-mga
force-pushed
the
fix_importer_scroll
branch
from
92b4c85 to
048788f
Compare
akien-mga
approved these changes
Jan 14, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98015
Attempts to do this by removing the PROPERTY_USAGE_UPDATE_ALL_IF_MODIFIED flag on a bunch of parameters where it doesn't seem nessecary. If anyone can explain why these are here, please let me know, otherwise, this should fix the UX problem outlined in the issue.