Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Forbid deleting inherited metadata properties #97986

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Oct 8, 2024

Fixes #97596

Before:

before.mp4

After:

after.mp4

@dustdfg dustdfg requested a review from a team as a code owner October 8, 2024 17:54
@AThousandShips AThousandShips added bug topic:editor cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 9, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 9, 2024
@KoBeWi KoBeWi requested review from a team and removed request for a team October 16, 2024 18:01
KoBeWi
KoBeWi previously approved these changes Oct 16, 2024
@dustdfg dustdfg force-pushed the metadata/forbid_deleting_inherited_metadata branch from f5e68d1 to 172f24f Compare October 17, 2024 07:42
@dustdfg dustdfg requested a review from a team as a code owner October 17, 2024 07:42
@KoBeWi
Copy link
Member

KoBeWi commented Oct 17, 2024

Crash when editing Resource:

CrashHandlerException: Program crashed
Engine version: Godot Engine v4.4.dev.custom_build (0b7c6e6b50d230786a1258d8f69bce5eb30b9568)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[0] PropertyUtils::get_property_default_value (C:\godot_source\scene\property_utils.cpp:142)
[1] EditorInspector::update_tree (C:\godot_source\editor\editor_inspector.cpp:3461)
[2] EditorInspector::_notification (C:\godot_source\editor\editor_inspector.cpp:4153)
[3] EditorInspector::_notificationv (C:\godot_source\editor\editor_inspector.h:481)
[4] Object::notification (C:\godot_source\core\object\object.cpp:878)
[5] SceneTree::_process_group (C:\godot_source\scene\main\scene_tree.cpp:1031)
[6] SceneTree::_process (C:\godot_source\scene\main\scene_tree.cpp:1108)
[7] SceneTree::process (C:\godot_source\scene\main\scene_tree.cpp:590)
[8] Main::iteration (C:\godot_source\main\main.cpp:4398)
[9] OS_Windows::run (C:\godot_source\platform\windows\os_windows.cpp:1772)
[10] widechar_main (C:\godot_source\platform\windows\godot_windows.cpp:181)
[11] _main (C:\godot_source\platform\windows\godot_windows.cpp:206)
[12] main (C:\godot_source\platform\windows\godot_windows.cpp:220)
[13] WinMain (C:\godot_source\platform\windows\godot_windows.cpp:234)
[14] __scrt_common_main_seh (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[15] <couldn't map PC to fn name>
-- END OF BACKTRACE --

You are casting to Node, but don't check whether the cast succeeded (it will be null for non-Nodes)

@dustdfg dustdfg force-pushed the metadata/forbid_deleting_inherited_metadata branch from 172f24f to cd462a2 Compare October 18, 2024 15:11
Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]>
Co-authored-by: Tomek <[email protected]>
@dustdfg dustdfg force-pushed the metadata/forbid_deleting_inherited_metadata branch from cd462a2 to edde380 Compare October 19, 2024 06:51
@dustdfg
Copy link
Contributor Author

dustdfg commented Nov 24, 2024

I am not going to do anything to update this PR. But it is not bad in IMO so I am not closing it... Over time some merge conflicts can occur... There are people with "write access" so if you need it you can correct it. I am abandoning this PR... If you want close it

@KoBeWi
Copy link
Member

KoBeWi commented Nov 25, 2024

This is already in mergeable state.

@Repiteo Repiteo merged commit 7104f20 into godotengine:master Nov 25, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 25, 2024

Thanks!

@dustdfg dustdfg deleted the metadata/forbid_deleting_inherited_metadata branch November 26, 2024 05:21
@akien-mga akien-mga changed the title Editor: forbid deleting inherited metadata properties Editor: Forbid deleting inherited metadata properties Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting metadata property in inherited scene does not persist
4 participants