Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI of sun angle in the sun/preview env popup #97747

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Improve UI of sun angle in the sun/preview env popup #97747

merged 1 commit into from
Oct 4, 2024

Conversation

adamscott
Copy link
Member

@adamscott adamscott commented Oct 2, 2024 •
edited
Loading

Before After
Capture d’écran, le 2024-10-02 à 14 09 01 Capture d’écran, le 2024-10-02 à 14 13 17
  • Titles are a little bit bigger than the subtitles.
  • Sun angle settings now display the "°" prefix and take the whole width of the column.
  • Buttons in post process take the whole width of the column.
  • Vertical separator takes less space.

@adamscott adamscott added this to the 4.4 milestone Oct 2, 2024
@adamscott adamscott requested a review from a team as a code owner October 2, 2024 18:16
@aaronfranke aaronfranke changed the title Fix UI of sun angle in the sun/preview env popup Improve UI of sun angle in the sun/preview env popup Oct 3, 2024
@adamscott adamscott mentioned this pull request Oct 3, 2024
Open
Calinou
Calinou approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

@akien-mga akien-mga merged commit 34920b4 into godotengine:master Oct 4, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:3d usability
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@adamscott @akien-mga @Calinou @Mickeon