Add unit tests for SceneMultiplayer
#97607
Merged
+292
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to help "fix" #43440
I implemented as many test I could without using an actual
MultiplayerPeer
(likeENetMultiplayerPeer
) or writing aMultiplayerPeer
mock.Using
ENetMultiplayerPeer
in this tests will imply that changes onENetMultiplayerPeer
could break tests onSceneMultiplayer
, which is not desirable. Also I'm not sure if I'll have enough control on howENetMultiplayerPeer
behaves to fully testSceneMultiplayer
.For the second option, I'll wait until a decision is made on #95224. If a mocking library is available, I'll revisit
SceneMultiplayer
to add more unit tests.Also I'm fixing a small typo on
SceneMultiplayer
docs.