Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify editor version buttons #97527

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Sep 27, 2024

There're three places that show a version button in the editor with slightly different texts:

Text Tooltip
Main Editor 4.4.dev Git commit date: %s
Click to copy the version information.
Project Manager v4.4.dev.custom_build [HASH] Git commit date: %s
Click to copy the version information.
About Dialog Godot Engine v4.4.dev.custom_build [HASH] Git commit date: %s
Click to copy the version number.

The text copied by clicking the button is the same v4.4.dev.custom_build [HASH].

This PR adds a dedicated EditorVersionButton to avoid repeating version button logic.

  • Uses the "copy the version information" version for tooltip.
  • Button text can be selected by an enum.

@timothyqiu timothyqiu added this to the 4.4 milestone Sep 27, 2024
@timothyqiu timothyqiu requested review from a team as code owners September 27, 2024 08:12
@timothyqiu timothyqiu force-pushed the version-button branch 2 times, most recently from d56b77d to 2b185aa Compare September 28, 2024 06:24
editor/gui/editor_version_button.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 8aabdc4 into godotengine:master Oct 1, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the version-button branch October 2, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants