CI: Update clang-format pre-commit hook to 19.1.0
#97483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Sep 26, 2024
| @@ -48,9 +48,9 @@ Error AudioDriverXAudio2::init() { | |||
| int latency = Engine::get_singleton()->get_audio_output_latency(); | |||
| buffer_size = closest_power_of_2(latency * mix_rate / 1000); | |||
|
|
|||
| samples_in = memnew_arr(int32_t, buffer_size * channels); | |||
| samples_in = memnew_arr(int32_t, size_t(buffer_size) * channels); | |||
There was a problem hiding this comment.
This was needed to prevent it from becoming:
Suggested change
| samples_in = memnew_arr(int32_t, size_t(buffer_size) * channels); | |
| samples_in = memnew_arr(int32_t, buffer_size *channels); |
That's a bug, but it's understandable that it gets confused. memnew_arr is a macro and it literally takes a type as first parameter, but the second parameter should be a size_t int.
AThousandShips
approved these changes
Sep 26, 2024
akien-mga
force-pushed
the
clang-format-19.1.0
branch
from
f023f46 to
c92a6c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.