Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant _3D_DISABLED check from csg module #97479

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Remove redundant _3D_DISABLED check from csg module #97479

merged 1 commit into from
Sep 26, 2024

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Sep 26, 2024

It even won't be considered for building so there is no any sense for compile time checks

config.py will disable building this module:

godot/modules/csg/config.py

Lines 1 to 2 in f7c567e

def can_build(env, platform):
return not env["disable_3d"]

@dustdfg
Remove redudant _3D_DISABLED check from csg module
e3eb5ee 
It even won't be considered for building so there is no any sense
for compile time checks

Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]>
@dustdfg dustdfg requested a review from a team as a code owner September 26, 2024 07:27
fire
fire approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense but it doesn't do much.

@fire fire changed the title Remove redudant _3D_DISABLED check from csg module Remove redundant _3D_DISABLED check from csg module Sep 26, 2024
@Chaosus Chaosus added this to the 4.4 milestone Sep 26, 2024
@akien-mga akien-mga changed the title Remove redundant _3D_DISABLED check from csg module Remove redundant _3D_DISABLED check from csg module Sep 26, 2024
@akien-mga akien-mga merged commit 8493a39 into godotengine:master Sep 26, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@dustdfg dustdfg deleted the csg_redudant_3d_disabled_check branch September 26, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@dustdfg @akien-mga @fire @AThousandShips @Chaosus