Add auto translate mode for cells in Tree
#97353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Oct 1, 2024
There was a problem hiding this comment.
This might just be an over-thinking. I'll change this to use Node::AutoTranslateMode if making AUTO_TRANSLATE_MODE_INHERIT mean "the same as Tree" is expected.
I would definitely use AUTO_TRANSLATE_MODE_INHERIT, a note in the set_auto_translate_mode description should be enough to clarify what it's doing.
|
Done. Changed to use |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make i18n for
Treeeasier if only some cells need auto translation.Otherwise users have to either rebuild the entire tree when locale is changed, or manually keep track of those special
TreeItems.Test project: tree-at.zip
A separateAutoTranslateModeis created becauseAUTO_TRANSLATE_MODE_INHERITcould mean "the same as its parentTreeItem. I don't see practical use of this behavior, but could be implemented in the future.AUTO_TRANSLATE_MODE_INHERITmeans "the same auto translate mode as theTree".