Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions to RDVertexAttribute's properties #97346

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add descriptions to RDVertexAttribute's properties #97346

merged 1 commit into from
Nov 27, 2024

Conversation

DevPoodle
Copy link
Contributor

This PR adds basic descriptions to all of RDVertexAttribute's properties.

@DevPoodle DevPoodle requested a review from a team as a code owner September 23, 2024 03:57
@DevPoodle DevPoodle force-pushed the vertex-attribute-docs branch 2 times, most recently from 4593138 to 111504a Compare September 23, 2024 05:00
@Mickeon Mickeon requested a review from a team September 23, 2024 07:10
@Mickeon Mickeon added this to the 4.4 milestone Sep 23, 2024
@Mickeon Mickeon added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 23, 2024
Mickeon
Mickeon reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I cannot say whether this is accurate information.

@DevPoodle DevPoodle force-pushed the vertex-attribute-docs branch from 7bbd15c to bd69df1 Compare September 23, 2024 12:40
@DevPoodle DevPoodle requested a review from Mickeon October 7, 2024 02:42
Mickeon
Mickeon approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do approve, but I reiterate the rendering team should take a look at it to make sure.

@Repiteo Repiteo merged commit 06f4bcd into godotengine:master Nov 27, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 27, 2024

Thanks!

@DevPoodle DevPoodle deleted the vertex-attribute-docs branch November 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@DevPoodle @Repiteo @clayjohn @Mickeon