Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in make_rst.py (Packedfloat64Array -> PackedFloat64Array) #97338

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

Ivorforce
Copy link
Contributor

Judging by how it's used, this may add the

The returned array is copied and any changes to it will not update the original property value

note to a few function docs.

@Ivorforce Ivorforce requested a review from a team as a code owner September 22, 2024 19:11
@Mickeon Mickeon added this to the 4.4 milestone Sep 22, 2024
@Mickeon Mickeon added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 22, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AThousandShips Literally unusable how dare you make such a blunder

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@clayjohn clayjohn merged commit d3e3b73 into godotengine:master Sep 22, 2024
19 checks passed
@clayjohn
Copy link
Member

Congratulations on your first merged contribution to the Godot repo!

@Ivorforce Ivorforce deleted the patch-2 branch September 22, 2024 20:29
@AThousandShips
Copy link
Member

Nice catch! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants