-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input: Change the default deadzone value for new actions from 0.5 to 0.2 #97281
Conversation
4c1d734
to
829933c
Compare
829933c
to
e92b84a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once those minor details are fixed this looks good to me!
e92b84a
to
b175602
Compare
b175602
to
b8c0d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning for changing the default value, as discussed in the linked proposal, makes sense to me.
Can you please double check, if it would make sense to make additional adjustments to the following location in the code base:
"deadzone": 0.5, |
I thought this could be left as it is, but I guess I could change that to the new default value (0.2) for the consistency's sake? I am not sure what to do with it. |
The action is only used for autocompletion tests at the moment, the dead zone isn't relevant there so changing it to the default makes sense to me. |
b8c0d13
to
d532eec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the input side, this looks good.
Thanks! And congrats for your first merged Godot contribution 🎉 |
It applies to built-in actions too, as these are often used by people for gameplay logic during prototyping. Built-in actions are not saved to Ideally, I think we should use custom deadzone handling for UI logic where it always uses a separate, fixed deadzone (e.g. as a project setting). This may be difficult to do though, so maybe reverting the deadzone for built-in actions only is preferable, even if it hurts the prototyping experience for users who don't create new actions (or people using the CharacterBody script template). |
…s `pressed` state Fixes godotengine#103360. Partial revert of changes in godotengine#97281 and godotengine#99135.
…s `pressed` state Fixes godotengine#103360. Partial revert of changes in godotengine#97281 and godotengine#99135.
This changes the default deadzone value for new actions from 0.5 to 0.2 as discussed in godotengine/godot-proposals#7069.
I have failed to rebase my previous year old PR, (#80299) so I pressed the "Sync" button in the Github's UI, not knowing it what it would do 😊👍️
Turns out it erases all your changes with no warning and without any way to undo what you have done.
Please check the changes I've recreated and sorry for the mess.
Bugsquad edit: