Remove direct render include in ExternalTexture
#97279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Sep 21, 2024
| @@ -30,7 +30,6 @@ | |||
|
|
|||
| #include "external_texture.h" | |||
|
|
|||
| #include "drivers/gles3/storage/texture_storage.h" | |||
There was a problem hiding this comment.
This include isn't used anywhere here (no GLES3 specific code here) so not sure why it was included, can't test on Android to confirm that this won't break the functionality there but I don't see how it could
|
I think this and previous incidents implies we should do an SCU build for MSVC (can't confirm if it happens on clang-cl) since these do crop up from time to time |
dsnopek
approved these changes
Sep 21, 2024
timothyqiu
reviewed
Sep 21, 2024
This include introduces `windows/platform_gl.h` into the include hierarchy which adds defines which break building on MSVC
AThousandShips
force-pushed
the
fix_gles3_include
branch
from
2d1fedf to
ccca41a
Compare
|
Thank you! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This include introduces
windows/platform_gl.hinto the include hierarchy which adds defines which break building on MSVCSee:
Related to: