Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better undo action names for localization editor #97275

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Better undo action names for localization editor #97275

merged 1 commit into from
Sep 24, 2024

Conversation

timothyqiu
Copy link
Member

  • Many add actions won't re-add existing files to the list.
    • These existing files should not be counted in the "%d entries added" message.
    • Don't create an undo action if nothing new is added to the list.
  • Use TTRN() to create better messages.

@timothyqiu timothyqiu added this to the 4.4 milestone Sep 21, 2024
@akien-mga akien-mga merged commit 6c1bbb3 into godotengine:master Sep 24, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the how-many branch September 24, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:i18n
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@timothyqiu @akien-mga