Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using Binutils AR with TEMPFILE on Windows #97188

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

alvinhochun
Copy link
Contributor

Set TEMPFILEARGESCFUNC1 to replace backslashes with forward slashes in paths.

This should fix a regression from #96407 (comment)

@alvinhochun alvinhochun requested a review from a team as a code owner September 19, 2024 14:15
Set `TEMPFILEARGESCFUNC`[1] to replace backslashes with forward slashes
in paths.

[1]: https://scons.org/doc/production/HTML/scons-user/apa.html#cv-TEMPFILEARGESCFUNC
@akien-mga
Copy link
Member

CC @noidexe if you can confirm whether that fixes your issue.

@noidexe
Copy link
Contributor

noidexe commented Sep 19, 2024

CC @noidexe if you can confirm whether that fixes your issue.

Yes, it just finished building. Thanks!

@akien-mga akien-mga changed the title Fix using Binutils AR with TEMPFILE on Windows Fix using Binutils AR with TEMPFILE on Windows Sep 19, 2024
@akien-mga akien-mga merged commit bea22d8 into godotengine:master Sep 19, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants