Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated note about not operator with String and StringName #97072

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Remove outdated note about not operator with String and StringName #97072

merged 1 commit into from
Sep 16, 2024

Conversation

iscke
Copy link
Contributor

@iscke iscke commented Sep 16, 2024

(introduced with #77227 as a temp fix until #74741 fixed it with 4.1, i believe)

@iscke iscke requested a review from a team as a code owner September 16, 2024 12:24
@AThousandShips AThousandShips requested review from a team September 16, 2024 12:26
@AThousandShips AThousandShips added this to the 4.x milestone Sep 16, 2024
Mickeon
Mickeon approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 16, 2024
@akien-mga akien-mga merged commit a75bace into godotengine:master Sep 16, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Mickeon Mickeon mentioned this pull request Nov 15, 2024
Open
@Mickeon Mickeon added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 15, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Nov 15, 2024

This would close godotengine/godot-docs#10030 if cherry-picked

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

Assignees
No one assigned
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@iscke @akien-mga @Mickeon @AThousandShips