Fix weird MSVC compilation error #97059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, MSVC doesn't appreciate uint8 math with enum constants.
I have no idea why I didn't have this error until a few weeks ago. The incriminating code was has not been changed recently which is super weird.
I still had the error even after updating VS2019.
The error is caused by the use of
<< FRAC_BITS
inside theif constexpr (sizeof(T) == 1) {
condition in_scale_bilinear
.I tried a few different things, but declaring FRAC_BITS as uint32 seems to be the only thing that works.
It doesn't hurt to clean the code though, using an enum to store constants is error prone, since the type is inferred by the compiler.
Error log: