-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight scripts used by current scene #97041
Conversation
I see overwhelming positivity behind this PR (not the proposal though). Perhaps it's worth continuing. Although, we're still struggling to find a good, non-hardcoded theme colour for it. Current PR uses transparency for a dimmer look, but I don't know if that'll play nice on light themes. |
a7719ea
to
87334f0
Compare
You can use a transparent gray ( |
I like the chosen look in the above screenshots, actually. I am concerned that the background on the fully black theme being completely invisible, though. Having it be subtle but noticeable is nice. As you said, it looks better in motion. It pops out when changing scenes around but it's not distracting. A friend has also expressed concern since this is restoring a feature users have gotten used to without. I believe most would see this as an upgrade, but it may warrant an Editor Setting, we'll see. |
Here's with transparent gray as suggested by @Calinou: |
87334f0
to
a07131b
Compare
Changed the color to |
a07131b
to
ac726f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say yeah as is. It's either this, or the feature is stripped out of the codebase because it currently is not working.
I have a gut feeling that the highlight will miss some scripts in the current scene, but we'll see. There's a huge desire to rework the script list someday, but that day is not as of writing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. Built-in scripts work, as well as scripts from instanced subscenes (they will be highlighted as being part of the current scene, which is technically valid).
The highlighting is a bit too subtle for me to easily notice it though. I suggest increasing the opacity to 0.125
.
ac726f7
to
f168d0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks! |
Closes godotengine/godot-proposals#10750
